Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading from fanbox user that is active on fanbox but suspended on pixiv halts the program and asks for name #1117

Closed
Zekira opened this issue Apr 28, 2022 · 2 comments

Comments

@Zekira
Copy link

Zekira commented Apr 28, 2022

Prerequisites

  • [Y] Did you read FAQ section in readme.md?
  • [Y] Did you test with the latest releases or commit ?
  • [Y] Did you search for existing issues in Issues?

Description

When I try to download from a user on fanbox that is suspended on pixiv, I will be asked for name, even if I already typed it before. The functionality seems to be that this should only happen once per user since it should now be on the database, but that doesn't seem to be case and I keep getting that halt for the same user:

Similar to this over a year old issue which was apparently fixed, but is still happening for me: #873

image

Is it possible to just get the name from the fanbox data instead of the pixiv data?

Steps to Reproduce

  1. Use any fanbox command that will point to an active use in Fanbox but suspended in pixiv.
  2. Input name when program asks. Not sure if it makes a difference but I input simple Hiragana here
  3. Let it finish
  4. Do same command for same user
  5. Name is still asked

Expected behavior: Program halts and asks for name

Actual behavior: Name should not be asked; preferrably the name should be retrieved from fanbox data instead of pixiv data

Log file:
pixivutil.log

Versions

20220311-beta3
You can get this information from executing PixivUtil2.py --help.
Latest version available in https://github.com/Nandaka/PixivUtil2/releases

@Nandaka
Copy link
Owner

Nandaka commented Apr 29, 2022

%artist% is not the same as the username %member_token%. I'm not sure if the name in Fanbox is always the same with the name in Pixiv or not as I don't use fanbox

@Nandaka
Copy link
Owner

Nandaka commented May 1, 2022

hmm, it is being validated because the fanbox filenameformats have %artist% or %member_token%.
https://github.com/Nandaka/PixivUtil2/blob/master/PixivFanboxHandler.py#L27-L41

Maybe I can add new format called %fanbox_name% and %fanbox_creator_id%' taken from body.user.nameandbody.creatorid` instead?
image

Nandaka added a commit that referenced this issue May 4, 2022
@Nandaka Nandaka closed this as completed Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants