Update to python 3.11 for faster startup #1199
Conversation
|
I don't understand. Anyone who doesn't PixivUtil2 in a docker won't benefit from this and the last Travis CI build was over two years ago. If you meant "Update docker file and .travis.yml to Python 3.11", yeah, that will work, but "for faster startup" means nothing. There is no "better user experience" coming from this pull request. The documentation states:
As far as I am aware, PixivUtil2 is not a "short-running" program. Furthermore, to prove this, benchmarks are required. What's the startup time for docker versus your branch? |
|
It's just saying that python 3.11 could make console programs startup faster and users will feel happy. dont see why you use a python file in docker, that way you have to mount the folder anyway. |
If a difference between 8ms and 100ms can be noticed by a user in real time, I highly, highly doubt it will increase their happiness. The difference is too insignificant to notice, it is a difference which makes no difference. Also, if you were even to suggest users to use python 3.11, again, these changes do not do that. They change the docker and travis ci files. If you want a user to use python 3.11 for a "faster" startup time, you need to modify the readme. |
|
The docker one can speed up the docker of python; The travis ci can run some pip install tests. It just notices that updating to python 3.11 has benefitted, and this PR is trivial actually. If the next release is bundling python 3.11, can close this PR. |
|
The next release of PixivUtil2 does not bundle python at all. You can close this PR yourself if you wish, else we're waiting on @Nandaka. |
Faster startup time can help command line program has a better user experience.
detail: https://docs.python.org/3.11/whatsnew/3.11.html#faster-cpython