fix(ui): always identify to posthog (#1900)

## Describe your changes

Fixes NAN-636

- Always call identify 
Some users are not identified correctly in PostHog. Looking at their
session it seems that they didn't go through sign-in, so I might be due
to the posthog cookie being deleted but not the nango session one.

- Fix inconsistent types

- Catch export types error

.eslintrc

@@ -56,6 +56,7 @@
         "@typescript-eslint/no-invalid-void-type": "warn",
         "@typescript-eslint/no-base-to-string": "warn",
         "@typescript-eslint/restrict-plus-operands": "warn",
+        "@typescript-eslint/consistent-type-exports": "error",
         "react/prop-types": "off",
         "@typescript-eslint/no-unused-vars": [
             "error",

packages/server/lib/controllers/user.controller.ts

@@ -3,8 +3,17 @@ import type { Request, Response, NextFunction } from 'express';
 import EmailClient from '../clients/email.client.js';
 import { errorManager, userService, getBaseUrl, isCloud, isEnterprise } from '@nangohq/shared';
 
+export interface GetUser {
+    user: {
+        id: number;
+        accountId: number;
+        email: string;
+        name: string;
+    };
+}
+
 class UserController {
-    async getUser(req: Request, res: Response, next: NextFunction) {
+    async getUser(req: Request, res: Response<GetUser>, next: NextFunction) {
         try {
             const { success, error, response } = await getUserAccountAndEnvironmentFromSession(req);
             if (!success || response === null) {

packages/server/lib/index.ts

@@ -1 +1,2 @@
-export { GetMeta } from './controllers/environment.controller.js';
+export type { GetMeta } from './controllers/environment.controller.js';
+export type { GetUser } from './controllers/user.controller.js';

packages/webapp/src/components/PrivateRoute.tsx

@@ -2,9 +2,13 @@ import { Outlet, Navigate } from 'react-router-dom';
 import { useMeta } from '../hooks/useMeta';
 import { useEffect } from 'react';
 import { useStore } from '../store';
+import { useAnalyticsIdentify } from '../utils/analytics';
+import { useUser } from '../hooks/useUser';
 
 const PrivateRoute: React.FC = () => {
     const { meta, error, loading } = useMeta();
+    const { user } = useUser();
+    const identify = useAnalyticsIdentify();
 
     const setStoredEnvs = useStore((state) => state.setEnvs);
     const setBaseUrl = useStore((state) => state.setBaseUrl);
@@ -23,6 +27,12 @@ const PrivateRoute: React.FC = () => {
         // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [meta, error]);
 
+    useEffect(() => {
+        if (user) {
+            identify(user);
+        }
+    }, [user, identify]);
+
     if (loading) {
         return null;
     }

packages/webapp/src/hooks/useUser.tsx

@@ -1,9 +1,9 @@
 import useSWR from 'swr';
-import { User } from '../types';
 import { swrFetcher } from '../utils/api';
+import type { GetUser } from '@nangohq/server';
 
 export function useUser() {
-    const { data, error, mutate } = useSWR<{ user: User }>('/api/v1/user', swrFetcher);
+    const { data, error, mutate } = useSWR<GetUser>('/api/v1/user', swrFetcher);
 
     const loading = !data && !error;
 

packages/webapp/src/utils/analytics.tsx

@@ -1,5 +1,5 @@
 import { usePostHog } from 'posthog-js/react';
-import { User } from './user';
+import type { User } from './user';
 
 export function useAnalyticsTrack() {
     const posthog = usePostHog();