Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth params: override from nango.auth #1040

Closed
bastienbeurier opened this issue Sep 21, 2023 · 0 comments
Closed

Auth params: override from nango.auth #1040

bastienbeurier opened this issue Sep 21, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bastienbeurier
Copy link
Member

Follows this resolved issue: Ask consent on Microsoft re-auth

From the community:

The plot thickens. Just got off the phone with a customer’s IT, they did admin consent in Azure, but their users were still continuing to be prompted for admin consent when attempting OAUTH as a non-admin user.
Digging deeper, apparently, setting prompt=consent is frowned upon for O365. There’s actually documentation on this, buried inside Azure Portal. I attached the full doc as a PDF below, but a couple quotes:
Note: Configuring an application with prompt=consent is not a best practice for developers. Azure AD might be receiving prompt=consent in authentication attempts, prompting an admin consent loop. Ask the developer to remove the prompt=consent property.
The Zoom application has a known issue where users are prompted with an admin consent request while signing in to the application, even when users have all permissions assigned in Azure. If you disable the Office 365 users can consent to enterprise applications accessing company data on their behalf option on the Zoom admin portal, then users won’t be prompted for admin consent.
So maybe Zoom defaults to prompt=consent too, but then has a admin configuration that removes it for orgs that have certain Azure configurations? I’d be down with defaulting to prompt=consent, but being able to flag prompt=consent off, depending on my client’s Azure configuration?

@bastienbeurier bastienbeurier self-assigned this Sep 21, 2023
@bastienbeurier bastienbeurier added the enhancement New feature or request label Sep 21, 2023
bastienbeurier added a commit that referenced this issue Sep 21, 2023
* [gh-#1040] Override auth params from nango.auth

* Add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants