Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: support GitHub apps #1071

Closed
bastienbeurier opened this issue Oct 4, 2023 · 1 comment · Fixed by #1089
Closed

GitHub: support GitHub apps #1071

bastienbeurier opened this issue Oct 4, 2023 · 1 comment · Fixed by #1089
Assignees
@khaliqgant
Labels
api Related to supporting new APIs.

Comments

@bastienbeurier
Copy link
Member

bastienbeurier commented Oct 4, 2023 •
edited

We already support OAuth apps for GitHub, but the more modern way to use the API is GitHub apps.

Auth docs for GitHub apps: https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app
@bastienbeurier bastienbeurier added the api Related to supporting new APIs. label Oct 4, 2023
khaliqgant added a commit that referenced this issue Oct 6, 2023
@khaliqgant
[gh-#1071] app flow initial implementation
e0fd829
khaliqgant added a commit that referenced this issue Oct 6, 2023
@khaliqgant
[gh-#1071] github app auth initial version
9b559b5
@bastienbeurier
Copy link
Member Author

@khaliqgant I was testing the GIthub App flow on another app to get clues on how they were reconciling the pro/post installation context, and it turns out they use a state parameter!!!! If that really works, it would solve a lot of our headaches:

Image

khaliqgant added a commit that referenced this issue Oct 9, 2023
@khaliqgant
[gh-#1071] Merge branch 'master' of github.com:NangoHQ/nango into gh-#…
c80874c 
…1071-github-apps
khaliqgant added a commit that referenced this issue Oct 9, 2023
@khaliqgant
[gh-#1071] Merge branch 'master' of github.com:NangoHQ/nango into gh-#…
ea7110d 
…1071-github-apps
khaliqgant added a commit that referenced this issue Oct 9, 2023
@khaliqgant
[gh-#1071] symlink logo
1b9b49a
khaliqgant added a commit that referenced this issue Oct 9, 2023
@khaliqgant
[gh-#1071] use more streamlined oauth flow with modal and closing aft…
ac6731a 
…er setup url callback
@khaliqgant khaliqgant mentioned this issue Oct 9, 2023
Merged
khaliqgant added a commit that referenced this issue Oct 9, 2023
@khaliqgant
[gh-#1071] github-app instead of github_app
43c67f1
khaliqgant added a commit that referenced this issue Oct 9, 2023
@khaliqgant
[gh-#1071] update test params
ffe6f82
khaliqgant added a commit that referenced this issue Oct 10, 2023
@khaliqgant
[gh-#1071] app token refresh logic
bf832ae
khaliqgant added a commit that referenced this issue Oct 10, 2023
@khaliqgant
[gh-#1071] remove unused
50d449d
khaliqgant added a commit that referenced this issue Oct 10, 2023
@khaliqgant
[gh-#1071] remove unused
f538da0
khaliqgant added a commit that referenced this issue Oct 10, 2023
@khaliqgant
[gh-#1071] better error message
3368199
khaliqgant added a commit that referenced this issue Oct 10, 2023
@khaliqgant
[gh-#1071] fix auth call update
66cd903
khaliqgant added a commit that referenced this issue Oct 10, 2023
@khaliqgant
[gh-#1071] add AppCredentials type
c68991f
khaliqgant added a commit that referenced this issue Oct 10, 2023
@khaliqgant
[gh-#1071] clean up getRecords call
de5d930
khaliqgant added a commit that referenced this issue Oct 10, 2023
@khaliqgant
[gh-#1071] add accessToken and expiresAt for app credentials
7654f89
khaliqgant added a commit that referenced this issue Oct 10, 2023
@khaliqgant
[Github #1071] GitHub apps (#1089)
60ded7a 
* [gh-#1071] app flow initial implementation

* [gh-#1071] github app auth initial version

* [gh-#1071] symlink logo

* [gh-#1071] use more streamlined oauth flow with modal and closing after setup url callback

* [gh-#1071] github-app instead of github_app

* [gh-#1071] update test params

* [gh-#1071] app token refresh logic

* [gh-#1071] remove unused

* [gh-#1071] remove unused

* [gh-#1071] better error message

* [gh-#1071] fix auth call update

* [gh-#1071] add AppCredentials type

* [gh-#1071] clean up getRecords call

* [gh-#1071] add accessToken and expiresAt for app credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khaliqgant khaliqgant

Labels
api Related to supporting new APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Github #1071] GitHub apps NangoHQ/nango
2 participants
@khaliqgant @bastienbeurier