Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for (external) secrets in sync scripts #763

Closed
3 tasks done
bastienbeurier opened this issue Jul 12, 2023 · 2 comments · Fixed by #997
Closed
3 tasks done

Support for (external) secrets in sync scripts #763

bastienbeurier opened this issue Jul 12, 2023 · 2 comments · Fixed by #997
Assignees
@khaliqgant
Labels
enhancement New feature or request

Comments

@bastienbeurier
Copy link
Member

bastienbeurier commented Jul 12, 2023 •
edited by khaliqgant

The use-case here is a sync script requiring the use of a bot token. This bot token is different per env (dev vs. prod). Given the sensitive nature of the token, it's best not to have it in clear in the sync script. The user asked to set this env variable in the Nango UI.

Implemented Features

  • Encrypts the environment variable at rest
  • Adds a getEnvironmentVariables method in the sdk for Sync/Action scripts only which returns the { name: string; value: string } pair
  • CLI doesn't compile if the getEnvironmentVariables method isn't awaited in a sync script
@bastienbeurier bastienbeurier added the enhancement New feature or request label Jul 12, 2023
@rguldener
Copy link
Member

Wouldn't "support for (external) secrets in sync scripts" be a clearer title?

@bastienbeurier bastienbeurier changed the title Support for env variables in sync scripts Support for (external) secrets in sync scripts Jul 12, 2023
@bastienbeurier
Copy link
Member Author

@khaliqgant here's a proposed design.

@khaliqgant khaliqgant self-assigned this Sep 11, 2023
khaliqgant added a commit that referenced this issue Sep 12, 2023
@khaliqgant
[gh-#763] env variables gui implementation
112bbb5
khaliqgant added a commit that referenced this issue Sep 12, 2023
@khaliqgant
[gh-#763] get env variables via the sdk
4f07bd2
@khaliqgant khaliqgant mentioned this issue Sep 12, 2023
Merged
2 tasks
khaliqgant added a commit that referenced this issue Sep 12, 2023
@khaliqgant
[gh-#763] Merge branch 'master' of github.com:NangoHQ/nango into gh-#763
12e5a49 
-env-variables
khaliqgant added a commit that referenced this issue Sep 13, 2023
@khaliqgant
[gh-#763] encrypt env variables if switching on encryption, warn abou…
a783fc7 
…t async usage
khaliqgant added a commit that referenced this issue Sep 13, 2023
@khaliqgant
[Github #763] env variables (#997)
a4f7d7e 
* [gh-#763] env variables gui implementation

* [gh-#763] get env variables via the sdk

* [gh-#763] encrypt env variables if switching on encryption, warn about async usage
khaliqgant added a commit that referenced this issue Sep 18, 2023
@khaliqgant
[gh-#763] env variable cleanup
9b0d269
khaliqgant added a commit that referenced this issue Sep 18, 2023
@khaliqgant
[gh-#763] version bump
eecb7a6
khaliqgant added a commit that referenced this issue Sep 18, 2023
@khaliqgant
[gh-#763] env variable cleanup (#1018)
37a15fa 
* [gh-#763] env variable cleanup

* [gh-#763] version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khaliqgant khaliqgant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Github #763] env variables NangoHQ/nango
3 participants
@rguldener @khaliqgant @bastienbeurier