Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timestamp from webhook payload for initial syncs #994

Closed
bastienbeurier opened this issue Sep 12, 2023 · 0 comments · Fixed by #1000
Closed

Remove timestamp from webhook payload for initial syncs #994

bastienbeurier opened this issue Sep 12, 2023 · 0 comments · Fixed by #1000
Assignees
@khaliqgant
Labels
enhancement New feature or request

Comments

@bastienbeurier
Copy link
Member

bastienbeurier commented Sep 12, 2023 •
edited

A developer outlined his workflow to get the latest changes from a sync:

When I receive a webhook for a triggered sync, I'm using getRecords to pull the data into our data model. The way I'm thinking to go about this to support successive syncs is to check if the sync type is INITIAL , if it is I don't add a delta to the getRecords call but if it's not the initial sync I will add the queryTimestamp to the getRecords delta field

To further simplified this logic, we can avoid sending a timestamp when the sync is INITIAL. That way, developers don't even need to check if syncs are INITIAL or not, and can just use the timestamp.
@bastienbeurier bastienbeurier added the enhancement New feature or request label Sep 12, 2023
khaliqgant added a commit that referenced this issue Sep 13, 2023
@khaliqgant
[gh-#975] remove queryTimeStamp if sync is initial
4179af5 
Resolves #994
@khaliqgant khaliqgant mentioned this issue Sep 13, 2023
Merged
khaliqgant added a commit that referenced this issue Sep 14, 2023
@khaliqgant
[Github #975] delete improvements (#1000)
bc4168b 
* [gh-#975] move data related services to its own directory

* [gh-#975] fix remaining reference

* [gh-#975] remove queryTimeStamp if sync is initial

Resolves #994

* [gh-#975] deleted property isn't optional

* [gh-#975] add nango_metadata property to all results

* [gh-#975] add metadata

* [gh-#975] test fixing and type improvements

* [gh-#975] fix tests and extract record property

* [gh-#975] types update

* [gh-#975] docs update

* [gh-#975] null for queryTimeStamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khaliqgant khaliqgant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Github #975] delete improvements NangoHQ/nango
2 participants
@khaliqgant @bastienbeurier