fix: deleting lots of records (track_deletes=true) #1878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a few days away from removing the records snapshot table but a customer is experiencing a sync failure in prod. so here is a quick fix to unblock the customer.
https://nangohq.slack.com/archives/C06FA6Q90BF/p1710782759958379
Deleting records (track_deletes=true) currently involves copying records from the snapshot table back into the records table. If there is a lot of records to copy, the query fails because the number of parameters goes beyond what's postgres supports, which I believe is 65k
Fixing this issue by inserting in chunks
Issue ticket number and link
https://linear.app/nango/issue/NAN-603/bug-deleting-too-many-records-track-deletes=true-results-in-an-error
Tested?
I have reproduced the issue and tested the fix locally