feat(metrics): [NAN-664] track more usage metrics in datadog #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaliqgant
commented
May 10, 2024
| @@ -1,41 +1,45 @@ | |||
| import tracer from 'dd-trace'; | |||
|
|
|||
| export enum Types { | |||
TBonnin
reviewed
May 10, 2024
|
|
||
| const action = LogActionEnum.TOKEN; | ||
|
|
||
| if (!isSync) { | ||
| metrics.increment(metrics.Types.GET_CONNECTION, 1, { accountId }); |
There was a problem hiding this comment.
does that create a metric per account? If yes are we ok about the cost increase? cc @bastienbeurier
Same question about the other ones below
There was a problem hiding this comment.
Yes. The description of the task states:
Because we pay per number of metrics, we should track 0-1 dimensions for each metric. I would only track accountID.
bodinsamuel
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add additional metric tracking
Issue ticket number and link
NAN-664
Checklist before requesting a review (skip if just adding/editing APIs & templates)