fix(axios): disable axios proxy when passing agent #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mithlesh135
commented
Jun 24, 2024
bodinsamuel
approved these changes
Jun 26, 2024
bodinsamuel
changed the title
|
@khaliqgant @TBonnin can you take a look too please? 👍🏻 |
TBonnin
approved these changes
Jun 26, 2024
added 3 commits
June 26, 2024 13:14
…h kicks in with https_proxy env set
TBonnin
force-pushed
the
fix/disable-axios-default
branch
from
7beef04
to
12c3f15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h kicks in with https_proxy env set
Describe your changes
As we are using httpProxyAgent we need to disable the axios default proxy so the httpProxyAgent is considered not the proxy with kicks in by default when we have https_proxy env set
Issue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)