-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integration-templates): [nan 1235] unanet integration #2399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -2877,6 +2877,101 @@ integrations: | |||
links: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file will soon become unmanageable :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've never touched this by hand, flows.js
just updates this programmatically.
unanet: | ||
actions: | ||
create-lead: | ||
endpoint: POST /lead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, do we recommend having action endpoints not prefixed with the integration name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we have anything official, but whenever you call an action you must pass in the provider config key so prefixing with the integration seems redundant
Describe your changes
Adds several actions to unanet
Issue ticket number and link
NAN-1235
Checklist before requesting a review (skip if just adding/editing APIs & templates)