Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration-templates): [nan 1235] unanet integration #2399

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

khaliqgant
Copy link
Member

Describe your changes

Adds several actions to unanet

Issue ticket number and link

NAN-1235

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

Copy link

linear bot commented Jun 24, 2024

Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -2877,6 +2877,101 @@ integrations:
links:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will soon become unmanageable :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've never touched this by hand, flows.js just updates this programmatically.

unanet:
actions:
create-lead:
endpoint: POST /lead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, do we recommend having action endpoints not prefixed with the integration name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we have anything official, but whenever you call an action you must pass in the provider config key so prefixing with the integration seems redundant

@khaliqgant khaliqgant merged commit 5713e95 into master Jun 24, 2024
20 checks passed
@khaliqgant khaliqgant deleted the khaliq/nan-1235-unanet-integration branch June 24, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants