fix(syncConfigs): handle new model_schema + display in the UI #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bodinsamuel
changed the title
khaliqgant
approved these changes
Jun 26, 2024
TBonnin
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes https://linear.app/nango/issue/NAN-1270/missing-data-in-api-ref-generation
Fixes https://linear.app/nango/issue/NAN-1292/show-types-in-ui
Correctly show new model in the UI
You can test using your own scripts and try with a new provider checking the available templates
Update
config.service.tsto return a StandardNangoConfig without going through unnecessary parsingWe were fetching from the DB and then passing through the parsing again for no reason except outputting the same type. It's confusing and prevent me to get rid of the nango-config.service.ts, so I slightly rewrote the formatter to make it output the right format directly. I also grouped the 3 functions that were querying the same data with different params.