Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): reconcile flag was turned off #2419

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

bodinsamuel
Copy link
Contributor

Describe your changes

  • Re up reconcile flag in CLI
    I put it to false by mistake, not entirely sure why this flag exists tbh (especially if always true)

  • Added an integration to check deletion is working

@bodinsamuel bodinsamuel self-assigned this Jun 27, 2024
Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it to false by mistake, not entirely sure why this flag exists tbh (especially if always true)

Thanks, reconcile isn't always set to true. It is set to false if not in auto confirm mode

@bodinsamuel
Copy link
Contributor Author

Thanks, reconcile isn't always set to true. It is set to false if not in auto confirm mode

Mmh then I messed up something, let me double check

@bodinsamuel
Copy link
Contributor Author

Okay so we agreed the reconcile flag is not useful because there is a confirmation endpoint, most probably legacy stuff to remove

@bodinsamuel bodinsamuel merged commit 60d621f into master Jun 27, 2024
20 checks passed
@bodinsamuel bodinsamuel deleted the fix/deploy-reconcile branch June 27, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants