Javascript client proxy #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgo
pushed a commit
to lgo/Pizzly
that referenced
this pull request
Jul 18, 2021
Javascript client proxy
bodinsamuel
added a commit
that referenced
this pull request
Mar 20, 2024
bodinsamuel
added a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Introducing the proxy methods (
.get();.post(), etc.) on the JS client.Migration guide
The new methods points to
/proxy/:integrationwhereas the previous methods pointed to/api/v4/functions/:integration/bearer-proxy. This path is still supported as legacy.Also we use
window.fetchhere, whereas the previous Bearer-js was using Axios. This might definetely break things. Depending on how much it breaks, we might want to reintroduce axios. But for now this is good enough to continue withfetch.