-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Integration Templates - Zendesk Tickets & Articles #937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the new templates!
return { ZendeskArticle: [] }; // Return statement is deprecated (will soon go away). | ||
} | ||
|
||
async function paginate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think this would be clearer if it was getNextPage
, since paginate
could imply that it will handle all of the pagination (for all pages).
return { ZendeskTicket: [] }; // Return statement is deprecated (will soon go away). | ||
} | ||
|
||
async function paginate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think this would be clearer if it was getNextPage, since paginate could imply that it will handle all of the pagination (for all pages).
const content = { | ||
pageNumber: contentPage ? contentPage.pageNumber + 1 : 1, | ||
articles: res.data.articles, | ||
has_more: res.data.meta.has_more, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should be camel case
tickets: any[]; | ||
nextPageEndpoint: string; | ||
totalResultCount: number; | ||
has_more: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should be camel case
encodeURIComponent
used in zendesk-articles to encode the cursor as it creates an error if inserted in raw format.Resolves #943