support adjoint gradients in cylindrical coordinate #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
August 30, 2021 21:29
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
+ Coverage 73.46% 74.37% +0.90%
==========================================
Files 13 13
Lines 4557 4573 +16
==========================================
+ Hits 3348 3401 +53
+ Misses 1209 1172 -37
|
|
Would be good to have a test, otherwise looks good! |
|
It seems that every cylindrical test case must run to the maximum runtime. In other words, none of the DFT fields are ever "converging"... We should probably look into that. |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* cyl * remove print * fix * bug * update * update * cyl * update * update * cyl * fix * update * update * cyl * update * update * rebase fix * rebase * rebase fix * minor fix * clean up * cyl test * typo * fix Co-authored-by: Mo Chen <mochen@Mos-MacBook-Pro.local>
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* cyl * remove print * fix * bug * update * update * cyl * update * update * cyl * fix * update * update * cyl * update * update * rebase fix * rebase * rebase fix * minor fix * clean up * cyl test * typo * fix Co-authored-by: Mo Chen <mochen@Mos-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for adjoint gradients in cylindrical coordinate. Solve #1570.