Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plot3d function #2305

Merged
merged 9 commits into from
Nov 17, 2022
Merged

Add plot3d function #2305

merged 9 commits into from
Nov 17, 2022

Conversation

SkandanC
Copy link
Contributor

@SkandanC SkandanC commented Nov 7, 2022

Update plot3d function.

Major changes:

  • Migrate from mayavi to vispy to create interactive 3D scenes

Minor changes:

  • Update docs for 3D visualization

Future work possibly:

  • Add capability to visualize fields as arrow vectors in specified slice planes

#2286

@joamatab
@thomasdorch
@smartalecH

@oskooi oskooi self-requested a review November 8, 2022 03:43
oskooi
oskooi reviewed Nov 8, 2022
View reviewed changes
python/visualization.py Outdated Show resolved Hide resolved
oskooi
oskooi reviewed Nov 8, 2022
View reviewed changes
python/visualization.py Show resolved Hide resolved
python/visualization.py Show resolved Hide resolved
oskooi
oskooi approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@oskooi oskooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stevengj stevengj merged commit a7cd7da into NanoComp:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskooi oskooi oskooi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SkandanC @oskooi @stevengj