Two improvements to API for BFAST feature #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2728 +/- ##
==========================================
- Coverage 74.07% 74.06% -0.01%
==========================================
Files 18 18
Lines 5396 5395 -1
==========================================
- Hits 3997 3996 -1
Misses 1399 1399
|
stevengj
reviewed
Nov 28, 2023
stevengj
reviewed
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses two of the three recommendations in #2609 (comment) for improving the API of the recently added BFAST feature:
need_bfast.bfast_kbarwithbfast_scaled_kwhich can be one of two types:Vector3orNone.The third recommendation for setting the Courant factor automatically will be added in a separate PR (pending further tests).