Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max gain: little bug #352

Closed
PA0JOZ opened this issue Nov 24, 2020 · 0 comments
Closed

Max gain: little bug #352

PA0JOZ opened this issue Nov 24, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@PA0JOZ
Copy link

PA0JOZ commented Nov 24, 2020

Hello,
In version 0.3.8 at the bottom of the screen Min gain and Max gain are shown.
However Max gain shows the same value as Min gain.
In line 665 of nanoVNASaver max_gain = min(..... must be max_gain = max(.....

Best Regards,
Jos, PA0JOZ
@gaionim gaionim mentioned this issue Dec 23, 2020
Merged
zarath added a commit that referenced this issue Dec 31, 2020
@zarath
Merge pull request #359 from gaionim/fix/352
320a61f 
fix #352
@zarath zarath added the bug Something isn't working label Dec 31, 2020
@zarath zarath closed this as completed Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zarath @PA0JOZ