Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

401 sweep points #369

Merged
merged 1 commit into from
Feb 19, 2021
Merged

401 sweep points #369

merged 1 commit into from
Feb 19, 2021

Conversation

galileo-pkm
Copy link
Contributor

Small change to enable 401 points on H4.

@halebopp2
Copy link

halebopp2 commented Feb 7, 2021

This fix does not work for me. I am using a SOLT 401pt calibration stored on my NanoVNA-H4 1MHZ to 1.5GHz. Whenever I add the 401 option and try to execute I get the following error:
2021-02-06 23:48:40,439 - NanoVNASaver.SweepWorker - ERROR - list index out of range
Traceback (most recent call last):
File "C:\Users\xxxx\Desktop\NanoVNA-H4\Software\nanovna-saver-master\NanoVNASaver\SweepWorker.py", line 80, in run
self._run()
File "C:\Users\xxxx\Desktop\NanoVNA-H4\Software\nanovna-saver-master\NanoVNASaver\SweepWorker.py", line 121, in _run
freq, values11, values21 = self.readAveragedSegment(
File "C:\Users\xxxxDesktop\NanoVNA-H4\Software\nanovna-saver-master\NanoVNASaver\SweepWorker.py", line 236, in readAveragedSegment
freq, tmp11, tmp21 = self.readSegment(start, stop)
File "C:\Users\xxxx\Desktop\NanoVNA-H4\Software\nanovna-saver-master\NanoVNASaver\SweepWorker.py", line 264, in readSegment
values11 = self.readData("data 0")
File "C:\Users\xxxx\Desktop\NanoVNA-H4\Software\nanovna-saver-master\NanoVNASaver\SweepWorker.py", line 279, in readData
tmpdata = self.app.vna.readValues(data)
File "C:\Users\xxxx\Desktop\NanoVNA-H4\Software\nanovna-saver-master\NanoVNASaver\Hardware\NanoVNA.py", line 132, in readValues
f"{data[2]} {data[3]}"))
IndexError: list index out of range

The other datapoint selection options work correctly including the 201 datapoint selection. Im a Fortran programmer unfamiliar with python so fixing this myself will require a steep learning curve. The only other bug I noticed is that the bandwidth is doubled on my NanonVNA from what is selected in nanovna-saver. Im using firmware 1.0.45 from DiSLord. OS: WIndows 10 running Python 3.9.

@galileo-pkm
Copy link
Contributor Author

I can't trigger that behaviour locally but even if I could it would not mean much because I'm not
a Python developer.
FWIW I have been using this on top of pull #368 and haven't seen any issues.

@zarath zarath changed the base branch from master to Development February 19, 2021 18:09
Copy link
Collaborator

@zarath zarath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing

@zarath zarath merged commit 4204bad into NanoVNA-Saver:Development Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants