Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison operators (
<
,>
, etc.) are not translated 1:1 to customisation methods (__lt__
,__gt__
, ...) in Python. Instead the type of the operands plays a role in determining on which of the two sides the customisation method is invoked (see Python Language Reference section 3.3.1). This meansa > b
can end up invokingb.__lt__(a)
rather thana.__gt__(b)
.This behaviour can causes infinite recursion in
Version.__lt__()
:Fix it by explicitly invoking the customisation methods we expect.