Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataclass fix for python3.11 compatability #572

Merged
merged 1 commit into from
Dec 18, 2022
Merged

dataclass fix for python3.11 compatability #572

merged 1 commit into from
Dec 18, 2022

Conversation

zarath
Copy link
Collaborator

@zarath zarath commented Dec 9, 2022

Bugfix

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Dataclasse with QColor objects would only work with a default_factory in Python dataclasses

Does this introduce a breaking change?

  • Yes
  • No

Other information

@easytarget easytarget mentioned this pull request Dec 13, 2022
Closed
@zarath
Copy link
Collaborator Author

zarath commented Dec 18, 2022

Merged to main

@zarath zarath merged commit f6e1868 into NanoVNA-Saver:main Dec 18, 2022
@easytarget easytarget mentioned this pull request Dec 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zarath