Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking for updates #674

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Fix checking for updates #674

merged 2 commits into from
Aug 8, 2023

Conversation

t52ta6ek
Copy link
Contributor

@t52ta6ek t52ta6ek commented Aug 6, 2023

Because the application version seems to be a generated value, a different method needed to be devised to try and determine what the current version number is. We now attempt scan the github release tags for the latest release version. If a newer version is detected, the application will display the current version and direct the user to click the link to view the latest release page.

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • [] Feature
  • [] Code style update (formatting, renaming)
  • [] Refactoring (no functional changes, no API changes)
  • [] Build-related changes
  • [] Documentation content changes
  • [] Other (please describe):

What is the current behavior?

Checking for updates will now return the current version and direct the user with the link provided to view the latest release page.

Issue Number: #673

What is the new behavior?

Checking for update works again.

Does this introduce a breaking change?

  • [] Yes
  • [] No

Other information

…erent

method needed to be devised to try and determine what the current version
nuber if. We now attempt scan the github release tags for the latest release
version. If a newer version is detected, the application will display the
current version and direct the user to click the link to view the latest
release page.
@t52ta6ek t52ta6ek requested a review from zarath as a code owner August 6, 2023 15:55
@zarath zarath merged commit 96dd232 into NanoVNA-Saver:main Aug 8, 2023
2 checks passed
@t52ta6ek t52ta6ek deleted the fixabout branch June 27, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants