Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX build for Windows executable #702

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

lpg2709
Copy link
Contributor

@lpg2709 lpg2709 commented Jun 5, 2024

When I build (for Windows) the version from commit a04d6d9b3995eabe26a41c9d5abc56678dd8b035 the final executable show the follow error if you try to execute:

Traceback (most recent call last):
  File "nanovna-saver.py", line 32, in <module>
  File "PyInstaller\loader\pyimod02_importers.py", line 419, in exec_module
  File "NanoVNASaver\__main__.py", line 31, in <module>
ModuleNotFoundError: No module named 'PyQt6.sip'

With this changes on build, the pyinstaller find correctly the Qt6 dependency and link on the final executable.

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

pyinstaller build the executable, but can't correct link the PyQt6.sip dependency.

Issue Number: 1

What is the new behavior?

pyinstaller find PyQt6.sip and Qt6 dependency, correctly.

Does this introduce a breaking change?

  • Yes
  • No

Other information

This change only affects the Windows compilation, may be useful for Linux and MacOS, when it was in interest to FIX their build.

@lpg2709 lpg2709 requested a review from zarath as a code owner June 5, 2024 12:26
@zarath zarath changed the base branch from main to windows_build June 19, 2024 11:54
@zarath zarath merged commit bdaddc3 into NanoVNA-Saver:windows_build Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants