Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate launcher icon from main activity #9

Merged
merged 2 commits into from
Mar 23, 2019
Merged

Separate launcher icon from main activity #9

merged 2 commits into from
Mar 23, 2019

Conversation

Vavun
Copy link

@Vavun Vavun commented Mar 22, 2019

Separate launcher icon from main activity so it can be disabled manualy without breaking app functional.

Some users at russian community reported that microg stop worhing after disabling main activity to hide microg from launcher (damn it is logical that it will break this activity functional !!)
In future it can be used as part of custom setting to hide launcher icon and system settings integration

Separate launcher icon from main activity so it can be disabled manualy without breaking app functional.

Some users at russian community reported that microg stop worhing after disabling main activity to hide microg from launcher (damn it is logical that it will break this activity functional !!)
In future it can be used as part of custom setting to hide launcher icon
@Vavun
Copy link
Author

Vavun commented Mar 23, 2019

@Nanolx and if possible check this master...Vavun:manage-acc

I think it will be better but I cant compile something at this moment.
Thanks

@Nanolx Nanolx merged commit 551f30b into Nanolx:master Mar 23, 2019
@Vavun
Copy link
Author

Vavun commented Mar 23, 2019

@Nanolx I'm sorry, I made some mess. Just noticed it.
PNG should not be included.

I uploaded them for another PR for vanilla microg and I dont know how they got into the master
microg#738

In this case, it should be either removed or add this XML to make it have sence.
https://github.com/microg/android_packages_apps_GmsCore/blob/96e66d83c8f47d2fd8740aaa9168c7e6798eddeb/play-services-core/src/main/res/mipmap-anydpi-v26/ic_core_service_app.xml

Sorry. My bad.

@Nanolx
Copy link
Owner

Nanolx commented Mar 23, 2019

No Problem, I'v merged vavun/patch-9

@Vavun
Copy link
Author

Vavun commented Mar 23, 2019

@Nanolx
Copy link
Owner

Nanolx commented Apr 2, 2019

Looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants