Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LEXIO-37227: Package Generators #3

Merged
merged 2 commits into from Dec 30, 2021
Merged

LEXIO-37227: Package Generators #3

merged 2 commits into from Dec 30, 2021

Conversation

ns-bdesimone
Copy link
Contributor

Overview

Adding package generators and configs to ns-poet similar to pypants. This logic is copy paste with the following exceptions:

  • removing all references to pants
  • removing all config variables that we no longer need in poetry
  • changes to make pre-commit pass

Testing

Manually testing in a talos branch. Publishing this wont effect anything because it is not in use yet.

Additional

We shouldn't need anything else in ns-poet to make poetry work with Fluxio :)

@ns-bdesimone ns-bdesimone requested a review from a team as a code owner December 30, 2021 19:00
@ns-bdesimone
Copy link
Contributor Author

drake is out so force merging.

@ns-bdesimone ns-bdesimone merged commit 18547f6 into main Dec 30, 2021
@ns-bdesimone ns-bdesimone deleted the LEXIO-37227/generators branch December 30, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boylancl Boylancl Boylancl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ns-bdesimone @Boylancl @ns-circle-ci