fix: panic when using CJK input methods in macOS #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's very useful for me |
|
Ok, I cannot verify this atm, but having approval from another member of the community is good enough for me ! Merging. |
This was referenced Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue and comment: #86 (comment)
When I am using a Chinese/Japanese input methods,
TISCopyCurrentKeyboardInputSourcewould return NULL, leading to a segment fault inCFDataGetBytePtr(layout)because layout is NULL.So I handled this case by using
TISCopyCurrentKeyboardLayoutInputSource, inspired by a similar case in VSCode.related issue: microsoft/vscode#23833 (comment)
and code: https://github.com/microsoft/node-native-keymap/blob/089d802efd387df4dce1f0e31898c66e28b3f67f/src/keyboard_mac.mm#L87
My environment:
MacOS 12.5 (Apple Silicon)
Rust 1.62.1