Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fixed some time errors of test_blockchain_sync_empty_blocks_first_and_second_empty_is_equal #1605

Conversation

onuratakan
Copy link
Member

Why ?

I am sending this pr because... (If you send for an issue please use "Closes #issuenumber" for here.)

Checking

  • No personal details (pass and etc.)

@onuratakan onuratakan temporarily deployed to Tests May 12, 2023 23:13 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Codecov May 12, 2023 23:13 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Tests May 12, 2023 23:13 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to LINT Tests May 12, 2023 23:13 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests May 12, 2023 23:13 — with GitHub Actions Inactive
@github-actions github-actions bot added the Tests label May 12, 2023
@onuratakan onuratakan temporarily deployed to UNIT Tests May 12, 2023 23:13 — with GitHub Actions Inactive
@viezly
Copy link

viezly bot commented May 12, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@onuratakan onuratakan temporarily deployed to UNIT Tests May 12, 2023 23:14 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests May 12, 2023 23:14 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests May 12, 2023 23:14 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1605 (9f4699d) into master (ee87afd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         133      133           
  Lines       10739    10739           
=======================================
  Hits        10479    10479           
  Misses        260      260           
Flag Coverage Δ
unittests 97.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/unit_tests/test_blockchain.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests May 12, 2023 23:33 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests May 12, 2023 23:33 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Codecov May 13, 2023 01:20 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Codecov May 13, 2023 01:20 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to LINT Tests May 13, 2023 01:20 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests May 13, 2023 01:20 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests May 13, 2023 01:20 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests May 13, 2023 01:20 — with GitHub Actions Inactive
@onuratakan onuratakan merged commit c3a8ec0 into master May 13, 2023
28 of 30 checks passed
@onuratakan onuratakan deleted the tests--Fixed-some-time-errors-of-test_blockchain_sync_empty_blocks_first_and_second_empty_is_equal branch May 13, 2023 01:21
@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests May 13, 2023 01:32 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests May 13, 2023 01:32 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant