Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Fixed mobile input empty bug #1629

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

onuratakan
Copy link
Member

@onuratakan onuratakan commented Jun 16, 2023

Why ?

Because on mobile every click are working two times.

Closes #1212

Checking

  • No personal details (pass and etc.)

@github-actions github-actions bot added the GUI label Jun 16, 2023
@restyled-io restyled-io bot temporarily deployed to Tests June 16, 2023 11:10 Inactive
@viezly
Copy link

viezly bot commented Jun 16, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@restyled-io restyled-io bot temporarily deployed to LINT Tests June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Tests June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Tests June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Tests June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Codecov June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Codecov June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Codecov June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:10 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:11 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:11 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:11 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:11 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 16, 2023 11:11 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 16, 2023 11:11 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 16, 2023 11:11 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 16, 2023 11:11 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 16, 2023 11:12 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 16, 2023 11:12 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 16, 2023 11:12 Inactive
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1629 (46c87dd) into master (ebc9baa) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1629      +/-   ##
==========================================
- Coverage   97.72%   97.71%   -0.01%     
==========================================
  Files         133      133              
  Lines       10595    10595              
==========================================
- Hits        10354    10353       -1     
- Misses        241      242       +1     
Flag Coverage Δ
unittests 97.71% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@restyled-io restyled-io bot temporarily deployed to FUNCTIONAL Tests June 16, 2023 11:32 Inactive
@restyled-io restyled-io bot temporarily deployed to FUNCTIONAL Tests June 16, 2023 11:32 Inactive
@restyled-io restyled-io bot temporarily deployed to FUNCTIONAL Tests June 16, 2023 11:34 Inactive
@restyled-io restyled-io bot temporarily deployed to FUNCTIONAL Tests June 16, 2023 11:34 Inactive
@onuratakan onuratakan merged commit c6b2b78 into master Jun 16, 2023
46 of 50 checks passed
@onuratakan onuratakan deleted the gui--Fixed-mobile-input-empty-bug3 branch June 16, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gui: Exception on wallet create on mobile zerodivision error
2 participants