Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockchain: Added different start times for shares #1637

Merged
merged 6 commits into from
Jun 26, 2023
Merged

blockchain: Added different start times for shares #1637

merged 6 commits into from
Jun 26, 2023

Conversation

onuratakan
Copy link
Member

Why ?

Closes #1636

Checking

  • No personal details (pass and etc.)

@viezly
Copy link

viezly bot commented Jun 26, 2023 •
edited

Changes preview:

Legend:

👀 Review pull request on Viezly

@onuratakan onuratakan self-assigned this Jun 26, 2023
@restyled-io restyled-io bot temporarily deployed to Tests June 26, 2023 20:04 Inactive
@restyled-io restyled-io bot temporarily deployed to Tests June 26, 2023 20:04 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 26, 2023 20:04 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 26, 2023 20:04 Inactive
@onuratakan onuratakan temporarily deployed to Codecov June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Codecov June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Tests June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Tests June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Codecov June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Codecov June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to LINT Tests June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to LINT Tests June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds June 26, 2023 20:16 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds June 26, 2023 20:17 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds June 26, 2023 20:17 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests June 26, 2023 20:17 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests June 26, 2023 20:17 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests June 26, 2023 20:17 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests June 26, 2023 20:17 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests June 26, 2023 20:17 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests June 26, 2023 20:17 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 26, 2023 •
edited

Codecov Report

Merging #1637 (927eed6) into master (40695a1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1637   +/-   ##
=======================================
  Coverage   97.71%   97.72%           
=======================================
  Files         133      133           
  Lines       10595    10629   +34     
=======================================
+ Hits        10353    10387   +34     
  Misses        242      242
Flag Coverage Δ
unittests 97.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
naruno/blockchain/block/shares.py 100.00% <100.00%> (ø)
tests/unit_tests/test_blockchain.py 100.00% <100.00%> (ø)
tests/unit_tests/test_transactions.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests June 26, 2023 20:34 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests June 26, 2023 20:34 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests June 26, 2023 20:36 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests June 26, 2023 20:36 — with GitHub Actions Inactive
@onuratakan onuratakan merged commit eeb7c30 into master Jun 26, 2023
40 of 41 checks passed
@onuratakan onuratakan deleted the 1636 branch June 26, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@onuratakan onuratakan

Labels
Blockchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blockchain: Adding different start times for shares
2 participants
@onuratakan @restyled-commits