Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Changed "None" return to "Password is not true" #1648

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Conversation

onuratakan
Copy link
Member

Why ?

Closes #1647

Checking

  • No personal details (pass and etc.)

@viezly
Copy link

viezly bot commented Jun 27, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@restyled-io restyled-io bot temporarily deployed to Tests June 27, 2023 10:12 Inactive
@restyled-io restyled-io bot temporarily deployed to Codecov June 27, 2023 10:12 Inactive
@restyled-io restyled-io bot temporarily deployed to Tests June 27, 2023 10:12 Inactive
@restyled-io restyled-io bot temporarily deployed to Codecov June 27, 2023 10:12 Inactive
@restyled-io restyled-io bot temporarily deployed to Codecov June 27, 2023 10:12 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:12 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to LINT Tests June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Tests June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to LINT Tests June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@restyled-io restyled-io bot temporarily deployed to Builds June 27, 2023 10:13 Inactive
@github-actions github-actions bot added the Lib label Jun 27, 2023
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 27, 2023 10:32 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 27, 2023 10:32 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 27, 2023 10:32 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 27, 2023 10:38 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 27, 2023 10:38 Inactive
@restyled-io restyled-io bot temporarily deployed to UNIT Tests June 27, 2023 10:38 Inactive
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1648 (9f84f7e) into master (9dea6d1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   97.73%   97.72%   -0.01%     
==========================================
  Files         133      133              
  Lines       10629    10629              
==========================================
- Hits        10388    10387       -1     
- Misses        241      242       +1     
Flag Coverage Δ
unittests 97.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
naruno/lib/sign.py 100.00% <100.00%> (ø)
tests/unit_tests/test_lib.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@restyled-io restyled-io bot temporarily deployed to FUNCTIONAL Tests June 27, 2023 11:00 Inactive
@restyled-io restyled-io bot temporarily deployed to FUNCTIONAL Tests June 27, 2023 11:00 Inactive
@restyled-io restyled-io bot temporarily deployed to FUNCTIONAL Tests June 27, 2023 11:02 Inactive
@restyled-io restyled-io bot temporarily deployed to FUNCTIONAL Tests June 27, 2023 11:02 Inactive
@onuratakan onuratakan merged commit f4b8444 into master Jun 27, 2023
46 of 49 checks passed
@onuratakan onuratakan deleted the 1647 branch June 27, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lib: Changing "None" return to "Password is not true"
2 participants