Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: Added android support for csv exports #1713

Merged
merged 14 commits into from
Aug 3, 2023
Merged

gui: Added android support for csv exports #1713

merged 14 commits into from
Aug 3, 2023

Conversation

onuratakan
Copy link
Member

@onuratakan onuratakan commented Aug 3, 2023 •
edited

Why ?

Closes #1688

Checking

  • No personal details (pass and etc.)

@viezly
Copy link

viezly bot commented Aug 3, 2023 •
edited

Changes preview:

Legend:

👀 Review pull request on Viezly

@onuratakan onuratakan temporarily deployed to Codecov August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Tests August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Codecov August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to Builds August 3, 2023 20:45 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests August 3, 2023 21:01 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests August 3, 2023 21:01 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests August 3, 2023 21:01 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests August 3, 2023 21:01 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests August 3, 2023 21:05 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests August 3, 2023 21:05 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to UNIT Tests August 3, 2023 21:05 — with GitHub Actions Inactive
@onuratakan onuratakan temporarily deployed to FUNCTIONAL Tests August 3, 2023 21:05 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited

Codecov Report

Merging #1713 (3e1e295) into master (6901361) will decrease coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
- Coverage   95.34%   95.34%   -0.01%     
==========================================
  Files         134      134              
  Lines       11468    11466       -2     
==========================================
- Hits        10934    10932       -2     
  Misses        534      534
Flag Coverage Δ
unittests 95.34% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
naruno/blockchain/block/save_block.py 95.06% <ø> (ø)
naruno/lib/settings_system.py 84.48% <100.00%> (-0.52%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@onuratakan onuratakan merged commit 653bd2b into master Aug 3, 2023
48 of 50 checks passed
@onuratakan onuratakan deleted the gui--Added-android-support-for-csv-exports branch August 3, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gui: Adding android support for csv exports
2 participants
@onuratakan @restyled-commits