Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 support & update dependencies #592

Merged
merged 19 commits into from Aug 3, 2022
Merged

Conversation

juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented May 30, 2022

This changes CI/CD tests to be run on Python 3.8-3.10 instead on 3.7-3.9 and updates mentions of Python version support to 3.8+. Wiki may still need updates for this.

Also

Compatibility of models trained with older dependencies should still be checked and documented.

Closes #589.

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #592 (f69d82d) into master (90007d7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
+ Coverage   99.48%   99.52%   +0.03%     
==========================================
  Files          86       86              
  Lines        5636     5636              
==========================================
+ Hits         5607     5609       +2     
+ Misses         29       27       -2     
Impacted Files Coverage Δ
tests/test_cli.py 100.00% <100.00%> (ø)
annif/backend/omikuji.py 97.61% <0.00%> (+1.19%) ⬆️
annif/analyzer/voikko.py 100.00% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90007d7...f69d82d. Read the comment docs.

Copy link
Member Author

@juhoinkinen juhoinkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge commit for resolving conflicts due to #587.

@juhoinkinen juhoinkinen marked this pull request as ready for review June 22, 2022 13:13
@juhoinkinen
Copy link
Member Author

juhoinkinen commented Jun 23, 2022

I run evaluation of just released Finto AI models with the upgraded dependencies: Models work with the usual warnings by sk-learn (e.g. Trying to unpickle estimator CountVectorizer from version 1.0.2 when using version 1.1.1. This might lead to breaking code or invalid results.) and evaluation results change just slightly for some data-sets.

New releases of connexion and NumPy were made just yesterday, so I upgraded them now again.

Simplemma v0.7.0 includes a breaking change, and I'm not sure how that should be fixed (can the simplemma.load_data() be just dropped?), so simplemma is left pinned to v0.6.*.

@juhoinkinen juhoinkinen changed the title Add Python 3.10 support Add Python 3.10 support & update dependencies Jun 23, 2022
@osma
Copy link
Member

osma commented Jun 23, 2022

I can fix the simplemma issue!

Merge to include upgraded Simplemma here too
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma
Copy link
Member

osma commented Aug 3, 2022

I think current master (with the flake8 fix, #598) should be merged to this PR branch and if everything still works, it can be merged to master.

Merge to include pytest-flake8 fix #598
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juhoinkinen juhoinkinen merged commit d244cf1 into master Aug 3, 2022
@juhoinkinen juhoinkinen deleted the python3.10-support branch August 3, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.10
2 participants