use Simplemma instead of pycld3 for language detection #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2022
Codecov ReportBase: 99.58% // Head: 99.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #626 +/- ##
==========================================
- Coverage 99.58% 99.54% -0.04%
==========================================
Files 87 87
Lines 5972 5968 -4
==========================================
- Hits 5947 5941 -6
- Misses 25 27 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This reverts commit 402b282.
osma
force-pushed
the
issue593-simplemma-language-detection
branch
from
365cd82
to
7af51fb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Rebased on current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is similar to PR #615 except it replaces the language detection previously performed using pycld3 with Simplemma based language detection (by @adbar)
I intend to benchmark this against PR #615 and the current status quo (with pycld3) in the near future.
Fixes #593