Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add --host to annif run #788

Merged

Conversation

dwinston
Copy link
Contributor

So that tutorial for web ui (https://github.com/NatLibFi/Annif-tutorial/blob/master/transcripts/web-ui.md) can be followed for docker installations.

So that tutorial for web ui (https://github.com/NatLibFi/Annif-tutorial/blob/master/transcripts/web-ui.md) can be followed for docker installations.
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@juhoinkinen
Copy link
Member

Thanks! Good have the option available also for other uses, despite it is no more needed for accessing the web UI when running with Docker (due to the update from Flask to Uvicorn or to a newer Docker version...?).

@osma removed the instruction to use the host option just yesterday from the exercise text, but from the exercise video it would have been harder to remove.

@juhoinkinen juhoinkinen merged commit 87b719d into NatLibFi:main May 21, 2024
15 checks passed
@juhoinkinen juhoinkinen added this to the 1.2 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants