Allow to get suggestion labels in Northern Sami #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: For this it is still necessary to restrict the languages selectable in "Suggestions language" menu depending on the project, because YKL and KAUNO vocublaries do not support Sami: a JS TypeError occurs if one tries to get suggestions in Sami when using YKL or KAUNO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@osma noted that now when Annif behind Finto AI uses an YSO version in which (some) concepts have labels in Sami (in addition to Finnish, Swedish and English), there could be an option in the "Suggestions language" menu for Sami (this menu just sets the language of the labels, independent on the selected project).
This (draft) PR adds that option.
However, currently those labels that don't have (yet) the label in Sami are displayed as "YSO identifiers" like
yso:p334in the suggestion results list. There could be some fallback display option for these cases, like showing the label in the language of the web site inside parentheses.Anyway, we could post pone this until the next model update round.
FYI @nikopartanen