Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy implementation #57

Merged
merged 5 commits into from
Aug 17, 2020
Merged

Add copy implementation #57

merged 5 commits into from
Aug 17, 2020

Conversation

ssilvonen
Copy link
Contributor

New pull request. Copy should be ready, select is still in progress.

Copy link
Contributor

@natlibfi-arlehiko natlibfi-arlehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the old select.spec.js so that'll tests and coverage check will pass.

@natlibfi-arlehiko natlibfi-arlehiko merged commit 5fbadc6 into next Aug 17, 2020
@natlibfi-arlehiko natlibfi-arlehiko deleted the feature-copy branch August 17, 2020 09:40
ammsalme added a commit that referenced this pull request Aug 10, 2023
* Add new implementation
* Add copy implementation (#57)
* Lots of initial development
* Add select reducer (#58)

* Lots of development and refactoring
* 6.0.0-beta.8

* new option compareWithoutTag and filter unique fields before add
* 6.0.0-beta.9

* more tests to compareWithoutTag
* Add new reducer parameters: skipIndicator1, skipIndicator2
* New test for compareWithoutIndicator1
* Fix tagPatternRegexp
* Support also reducers that return { base, source }
* 6.0.0-beta.10

* General fixes
* main reducer loop in index
** fix result for old school reducers
** use non-mutating variables/parameters

* update copy-reducer to handle input in ({base, source}) -format in addition to (base, source) -format
* update select-reducer to handle input in ({base, source}) -format in addition to (base, source) -format
* add extra test-spec that uses ({base, source}) input format for both copy- and select reducers
* update npm test and npm test:base
* more debug, use debug and debugData for debug
* Update deps

* 6.0.0-beta.11

* Maintenance update (#62)
* 7.0.0-alpha.1

* Maintenance2 (#63)
* 7.0.0-alpha.4

---------

Co-authored-by: natlibfi-arlehiko <natlibfi-arlehiko@users.noreply.github.com>
Co-authored-by: ssilvonen <46997466+ssilvonen@users.noreply.github.com>
Co-authored-by: natlibesa <31346486+natlibesa@users.noreply.github.com>
Co-authored-by: Minttu Hurme <ammsalme@users.noreply.github.com>
Co-authored-by: nvolk <nicholas.volk@helsinki.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants