Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Melkehitys-1541 #208

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Melkehitys-1541 #208

wants to merge 6 commits into from

Conversation

natlibfi-jonollil
Copy link
Contributor

Updates:
node-uuid -> uuid,
http-status-codes -> http-status,
marc-record.js -> @NatLibFi/marc-record

Implemented:
Melinda-common and api-client

@natlibfi-jonollil natlibfi-jonollil changed the title update uuid, http-status, marc-record. implemented commons and api-cl… Melkehitys-1541 Jun 12, 2020
@natlibfi-jonollil natlibfi-jonollil changed the base branch from master to dev June 12, 2020 12:37
natlibfi-arlehiko
natlibfi-arlehiko suggested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@natlibfi-arlehiko natlibfi-arlehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Disable only subfieldValues validation of MarcRecord because Aleph generates subfields without values.

Records with no fields or no subfields should not occur (And if they do we need to know so they can be fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natlibfi-arlehiko natlibfi-arlehiko natlibfi-arlehiko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@natlibfi-jonollil @natlibfi-arlehiko