make the left colour changeable with lcolor param #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the left colour background of the badge through this param. Same as labelColor param in shields.io if none given, set "grey" as default as shield.io use. Signed-off-by: rzlamrr <rzlamrr.dvst@protonmail.com>
|
Thanks again for this pull request. Looking purely at the changes, it looks like that it should work as expected. But I'll be checking again later before deploying! |
Thanks for your response @Nathan13888 . I have tested all of my pr and everything went smoothly |
Nathan13888
added a commit
that referenced
this pull request
May 31, 2021
|
btw I just wanted to mention, thanks for submitting these pull requests @rzlamrr I'm going to commiting some changes that make all of the badge options into a separate struct. Seeing as how messy it was to implement a new option before, it should make things cleaner for the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.