Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for maxZoom #40

Merged
merged 1 commit into from
Jan 4, 2023
Merged

add support for maxZoom #40

merged 1 commit into from
Jan 4, 2023

Conversation

johnwesely
Copy link

Details

This PR adds support for maxZoom prop to the GMapMap component.

Steps to Test

  1. point to fork in existing project or create new project pointing to fork
  2. add ':maxZoom="x"' prop to GMapMap component
  3. confirm max zoom is limited to provided value
  4. confirm not providing maxZoom prop does not break functionality

@netlify
Copy link

netlify bot commented Jan 3, 2023 •
edited

✅ Deploy Preview for vue-google-maps-community-fork canceled.

Name Link
🔨 Latest commit d160685
🔍 Latest deploy log https://app.netlify.com/sites/vue-google-maps-community-fork/deploys/63b489985b61300009251119

@NathanAP NathanAP self-assigned this Jan 4, 2023
@NathanAP NathanAP added the enhancement New feature or request label Jan 4, 2023
@NathanAP
Copy link
Owner

NathanAP commented Jan 4, 2023 •
edited

Hello!

Thank you so much for this PR! Its working like a charm :) I'll accept it now and publish into npm as soon as I can.

Please let me know if there is something else you think we should do before publishing.

Edit: this will be 0.2.0

@NathanAP NathanAP self-requested a review January 4, 2023 12:21
@NathanAP NathanAP merged commit 2665578 into NathanAP:main Jan 4, 2023
@NathanAP
Copy link
Owner

NathanAP commented Jan 4, 2023

Its up! Thanks again!

@johnwesely
Copy link
Author

Glad I could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanAP NathanAP NathanAP approved these changes

Assignees

@NathanAP NathanAP

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnwesely @NathanAP