Attempt to fix closeclick issue in InfoWindow #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- propagate google maps InfoWindow's closeclick event to the parent component however, re-open the InfoWindow to ensure, its state is set solely by the opened prop of the InfoWindow component - do not emit closeclick in the _openInfoWindow() method triggered by the watcher on the opened prop. closeclick should only be triggered, when the user atually clicked close
✅ Deploy Preview for vue-google-maps-community-fork canceled.
|
|
If someone uses this and wants to help us improve it, please let us know. I'll leave it here some days to see if someone appears. Otherwise I'll accept it. Thanks again for your help! |
NathanAP
added
bug
NathanAP
removed
help wanted
NathanAP
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate google maps InfoWindow's closeclick event to the parent component however, re-open the InfoWindow when the event is received in order to ensure, its state is set solely by the "opened" prop of the InfoWindow component
Do not emit closeclick in the _openInfoWindow() method triggered by the watcher on the opened prop. closeclick should only be triggered, when the user atually clicked close