Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuildSigLookup() does not check for unset conf variable external_sig_link before access. #27

Closed
NathanGibbs3 opened this issue May 10, 2019 · 0 comments
Closed

BuildSigLookup() does not check for unset conf variable external_sig_link before access. #27

NathanGibbs3 opened this issue May 10, 2019 · 0 comments
Assignees
@NathanGibbs3
Labels
bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Projects
Code Quality - Unset Items
Milestone
1.4.6

Comments

@NathanGibbs3
Copy link
Owner

NathanGibbs3 commented May 10, 2019 •
edited

Item Description
File: includes/base_signature.inc.php
Class: N/A
Function: BuildSigLookup()
Similar Issues: https://github.com/NathanGibbs3/BASE/projects/2
Misc. Info.: Error only happens when parameter $style=1, for HTML output.

Expected Behavior:
App checks the existence of the conf var in the $GLOBALS array via in_array() before testing it's value..
Current Behavior:
Function does not check for unset conf variable external_sig_link.
This condition would occur if external_sig_link is not set in base_conf.php
This results in the following error(s) in production
PHP Notice: Undefined index: external_sig_link in path redacted /includes/base_signature.inc.php on line 439
PHP Notice: Undefined index: external_sig_link in path redacted /includes/base_signature.inc.php on line 449
PHP Notice: Undefined index: external_sig_link in path redacted /includes/base_signature.inc.php on line 459
@NathanGibbs3 NathanGibbs3 added bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. labels May 10, 2019
@NathanGibbs3 NathanGibbs3 mentioned this issue May 10, 2019
Closed
@NathanGibbs3 NathanGibbs3 mentioned this issue May 17, 2019
Closed
This was referenced Jun 12, 2019
Closed
Closed
Closed
@NathanGibbs3 NathanGibbs3 added this to Needs triage in Code Quality - Unset Items Jun 17, 2019
@NathanGibbs3 NathanGibbs3 mentioned this issue Jun 18, 2019
Closed
Code Quality - Unset Items automation moved this from Needs triage to Closed Jun 26, 2019
@NathanGibbs3 NathanGibbs3 self-assigned this Jun 26, 2019
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Sep 13, 2020
@NathanGibbs3 NathanGibbs3 mentioned this issue Sep 27, 2020
Closed
@NathanGibbs3 NathanGibbs3 added the Stability Issue impacts or is related to App Stability. label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Projects
Code Quality - Unset Items
  
Closed
Milestone
1.4.6
Development

No branches or pull requests
1 participant
@NathanGibbs3