This repository has been archived by the owner on Jul 7, 2022. It is now read-only.
Fixed issue when wrapper became null during close. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good fix. Thanks. Will try and push another version to npm later... |
|
Thanks :) |
|
Any update on when you'll be able to push up the new release? |
|
@NathanaelA Any update? |
|
@djoli - Sorry for the delay; have been swamped trying to handle the proplugins.org stuff. I have published the new version... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this library as the basis on a project using websockets for STOMP communication. I have experienced an issue which appears to be related to closing the socket, likely a side effect of using this library under the STOMP library, where essentially the wrapper becomes null at some point between the if check and the timeout execution. I understand you are no longer supporting advancement of this library, so I implemented a very small fix to this issue, which I don't believe will cause any problems elsewhere, and will alleviate my issue. Thanks for taking the time to review the change, and please let me know if you would rather I tidy it a little more.