Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12/11 Crossover Grading Review Ticket #2

Open
JasonGao76 opened this issue Dec 11, 2023 · 6 comments
Open

12/11 Crossover Grading Review Ticket #2

JasonGao76 opened this issue Dec 11, 2023 · 6 comments

Comments

@JasonGao76
Copy link
Collaborator

JasonGao76 commented Dec 11, 2023

Project WRONG - Crossover Grading Review Ticket

Pages

Video link: https://drive.google.com/file/d/1hK5Y2t-kSYxOn69wNvJhP66ZGkrCRGTJ/view?usp=sharing
Miscellaneous:

  • In the beginning of the project, we all worked together to envision what the project should look like and created the Canva page seen on the home page and a brief plan in the repository summarizing the parts of the project and who works on what
  • We also created a separate group chat to discuss the parts of the project and ensure all the parts are done by the due date

Nathan: Carousel

Analytics: https://github.com/Nathaniel633
Issues:

  • For our Project WRONG where we helped teach binary with the use of hand signs, I primarily worked on the front page index.md with an added index.css that I referenced for styling. In addition to this, I imported the scss from the Teacher Portfolio repository for the Teacher 2.0 Binary Calculator, manipulated the colors and sizing for the buttons, and used that to create the front page buttons. I encountered the issue of the spacing of the buttons, as they would either all be adjacent to one another or all shifted from the center, but I fixed this with the help of a peer from another group by adding the “gap” style. I also wanted the links on the front page to open on a new tab, so I added the href target=“_blank” css to make each link open in a new tab upon click. With the images themselves, I encountered problems with the linking as I had originally saved them as files in our images folder, which was manipulated for the image carousels. To combat this, I uploaded the images to postimage to create permanent links for them, to be saved elsewhere.

Key commits:

  • 709994c, import sass from teacher portfolio for buttons
  • 0e96d5a, add image of canva page and add index to front page

Summary of code:

  • image

Grayson: Carousel and Number Quiz

Analytics: https://github.com/Delta760
Issues:

  • In this code, I created the binary-to-decimal quiz. I had trouble randomizing the questions after clicking the next question button and getting the code to accept 0-31 inputs. I fixed this by using the built-in JavaScript randomizer code. I fixed the input amount problem by creating a library and storing the index as the same value of the binary code.

Key commits:

Summary of code:

  • image

Will: Carousel

Analytics: https://github.com/willbartelt15
Issues:

  • During my code some of the issues I encountered was figuring out how to make the images pop up in the carousel. It turns out that the image link I was using weren't taking me to the right pathway. I had to update the image links and use an external link to make them pop up. Another Issue I encountered was fixing the cycling function to shuffle between the images. I had to update the code and fix the code that shuffled between slides.

Key commits:

  • 3651b96, create carousel code and margins
  • 87cff97, add images to carousel

Summary of code:

  • image

Jason: Binary Hand Quiz

Analytics: https://github.com/JasonGao76
Issues:

  • One issue we ran into were the image links not properly linking to the right image. Initially, we attempted to use relative paths but that never worked, even after hours of testing. Thus, I resorted to using outside image uploaders. I first used discord which worked for a week, but then the image links broke and it also wasn't compatible with school wifi, so I had to search for another one. I then looked at Google Photos but the links were massive, so that wasn't practical as well. Finally, I found postimage, and it worked perfectly with a concise link and that's what we used for the rest of project.
  • When writing the key functionality for the random images script, I encountered numerous problems as this was one of the first times I've coded in Javascript, and the biggest problem was figuring out how to get random indexes for the array. I encountered problems with the math function and spent an hour tracking down the code, variables, and more to figure out how the indexes were made, if they were properly made, and how it grabbed the link and if it did it correctly.
  • Something we can still work on is making the code less redundant as many of the same procedures are repeated but for different questions, so loops or other methods can be used to reduce the lines of codes

Key commits:

  • 3004b34, created all files and did backbone / key functionality of all, but not debugged or fixed
  • b5e64a3, fixed links and polished up quiz

Summary of code:

  • image
  • image
  • image

Rayyan: Binary Hand Quiz

Analytics: https://github.com/RayyanDarugar
Issues:

  • As me and Jason coded our Binary Picture Quiz, we ran into a bunch of issues to solve. In development, we reviewed all in Jupyter Notebooks. On the Jupyter page, we couldn't get the answer Key function to run from inside of one of our scripts. To fix this, I changed the function to a variable array with answers defined in each line, and migrated the script folder to outside of our _notebooks. Additionally, when we started testing on the GitHub page, for some reason every part of our code broke. It wasn't reading scripts properly, so I troubleshooted for a while until I realized I could fix it by changing from a IPYNB to a .md. From there on out, I just fixed minor styling issues and modified the page to look better.

Key commits:

  • 94592ae, created group plan
  • c5ec40e, fixed key problem with answer key not defining

Summary of code:

  • image
  • image + also shifted everything to anther file
@RyanZLiu
Copy link

RyanZLiu commented Dec 12, 2023

Individual Review "Ryan Liu" grading "Nathan O"

  • Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

  • Video in CPT caption style , includes Web demo of key contribution to project, 1 minute (0.85)
  • Issue(s) that show plans/progress to team objectives (0.75)
  • Highlights of key commit(s) in Issues, summarizes code contributions (0.8)
  • Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks (0.8)

Per check.
0.55 not attempted/no check
0.7 attempted, incomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.

Freeform comment.
Provide positives and growth summary.
Justify or comment on final score.
Be sure to provide extra details on anything below 0.7 average or above 0.8.

0.85+0.75+0.8+0.8
Average: 0.8/0.9.
Worked primarily on css and making the website look nice. Showed a lot of work and collaboration with teammates to create home page and organize everything well. He created and designed his own buttons which their own specific functions (ex: directing user to their project links). Next time, maybe also be involved a little bit in coding the projects using python/javascript. Also somethings to consider for css: you could work on creating a more custom background. It also could've been cool if you created more custom & unique buttons because the current one is kind of bland and basic.

@monke7769
Copy link

monke7769 commented Dec 12, 2023

Individual Review Hayden Chen grading Grayson Guyot

  • [ 0.85 ] Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

  • [ 0.9 ] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
  • [ 0.8 ] Issue(s) that show plans/progress to team objectives
  • [ 0.82 ] Highlights of key commit(s) in Issues, summarizes code contributions
  • [ 0.83 ] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks

Per check.
0.55 not attempted/no check
0.7 attempted, incoomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.

SCORE: 0.84.
Demonstrated mastery and knowledge of the randomization algorithm (Fisher-Yates) and showed code well. The website broke for some reason during class, but the video showed proof of the binary to decimal quiz working well. Code was explained well and Grayson demonstrated good teamwork skills with Will B. The video was well-made but there were unnecessary subtitles just saying "Grayson" which could have been removed (since it was blocking some of the screen).
Next time, you could potentially have created a nicer, aesthetic CSS for the user's eyes. Or, you could have written explanations for each of the binary to decimal conversions and displayed them using JS if the user got the conversion wrong.

@SrijDude3416
Copy link

SrijDude3416 commented Dec 12, 2023

Individual Review: Srijan Atti grading Jason Gao

  • [0.85] Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

  • [0.8] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
  • [0.8] Issue(s) that show plans/progress to team objectives
  • [0.8] Highlights of key commit(s) in Issues, summarizes code contributions
  • [0.8] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks

Per check.
0.55 not attempted/no check
0.7 attempted, incomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.

Score: (0.85 + 0.8 + 0.8 + 0.8 + 0.8)/5 = 0.81

Jason exhibited mastery over his portion of the project and displayed high levels of problem solving while overcoming problems such as storing and displaying images. His video was perfect with captions, no audio, and high level descriptions of his code and demos of his project. The project harnessed skills from last trimester such as input checking, output as well as newer skills such as CSS and code cleanliness.
Growths: Would be cool if you could add a page that lets you use the camera to ask the computer what number you're holding up with your hand. Also, possibly make the CSS even better with maybe a dynamic background or something to tie everything together.

@monke7769
Copy link

monke7769 commented Dec 12, 2023

Individual Review Hayden Chen grading Will Bartelt

[ 0.86 ] Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.
Individuals Video, Issue(s), Commits(s)

[ 0.9 ] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
[ 0.8 ] Issue(s) that show plans/progress to team objectives
[ 0.85 ] Highlights of key commit(s) in Issues, summarizes code contributions
[ 0.85 ] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks
Per check.
0.55 not attempted/no check
0.7 attempted, incoomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.

SCORE: 0.85.

Carousel code was complete and very impressive. Functional according to the video (broke on the day of review). The key commit was explained well with knowledge of the code, and the carousel JS was completed with functions, indicating good skill. Will showed great understanding and was well-spoken about his part of the code. He also showed that there was a great deal of teamwork involved.
Growth: the screenshotted code was very repetitive and could have been more concise through the use of JS. (just a suggestion). Additionally, the CSS could have been improved from the default, and perhaps the frontpage Canva design might have been resized to fit the page since it was a bit small to read.

@iwu78
Copy link

iwu78 commented Dec 13, 2023

Team Review Ian grading Rayyan

  • The team should have a Web Pages that teach: Binary, Data, Data Structures, Data Abstraction.
    Main goal of project is to teach binary , 0.9/0.9

Team Review ticket containing key Team and individual contributions

  • Growth/Accomplishments in work is according to historical Team Plan, or they show revisions to plan according to work
    Goes above and beyond original outlined plan, which is displayed and complete with images 0.9/0.9
  • Short falls/Improvement that could be made in Work or Team Plan, team highlights next steps or improvements that could be made
    Discussed but not placed into plan, 0.7/0.9
  • Showing key accomplishments according to requirement in Frontend such as Binary Math, ASCII, Unicode, Color Codes, Logic Gates, etc.
    Follows requirements, website shows Binary, 0.8/0.9
  • Showing key user interaction and learning(s). For instance how you visualized Algorithms, Data, Data Structures. Or, how you provided response and Feedback to user on their success in learning.
    Interaction is demonstrated in video and website, learnings are shown in video, 0.9/0.9

Per check.
0.55 not attempted/no check
0.7 attempted, incoomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.

Comments:
Project was well designed and it is definitely possible to be used to teach binary, which is a key skill. The project contains three pages, each meant to teach binary. Plan is not a post, but placed on homepage, but this works well as a basic explanation of binary. The completed project goes beyond the original plan, and plan was followed well. Video is well made and complete with captions, going into detail about code and demonstrating project. I especially liked how the project, rather than expand and continue into more complicated concepts that applied binary and color codes, etc, instead sought to explain and teach the basics of binary in a way that makes it easier to understand for a new learner. The use of images, while much more complicated to create in terms of code, effectively visualizes binary in a way that makes it easy to follow. On that topic, however, the learn page does not explain what binary is, and rather directly gives practice and matches a number to an image. While this may work for some, an explanation of how binary works would have benefitted the project. Another place for improve is the CSS of the project. While a plan on the homepage works, creating a homepage with links would've looked more appealing, as well as customizing the CSS of the project more to fit the project topic. Overall, even though some minor changes could've improve the website, the website was well designed, and went beyond the requirements of the project.

Score: 0.85/0.9

@iwu78
Copy link

iwu78 commented Dec 13, 2023

Individual Review Ian grading Rayyan

  • Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.
    Demonstrates contributions to projects in key commits, visible in github analytics, 0.85/9

Individuals Video, Issue(s), Commits(s)

  • Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
    Video shows contributions and demonstrates his part of project, as well as highlighting code, 0.85/9
  • Issue(s) that show plans/progress to team objectives
    Issue described in detail in person, not present in Github, 0.75/9
  • Highlights of key commit(s) in Issues, summarizes code contributions
    Key commits highlight issues faced and code contributions, as well as solutions to issues, 0.85/9
  • Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks
    Participates and does his part, relatively consistent, 0.8/9

Per check.
0.55 not attempted/no check
0.7 attempted, incomplete, but some runtime
0.8 mastery and runtime
0.9 above and beyond.

Freeform comment.
Code for test was effective and well written. Issues were outline and discussed, especially with images, and debugging and finding errors is much more work, since images are more finnicky. Video showcasing work was complete with captions, and highlighted work on the projects. Worked on HTML, CSS, and JS, and video shows that. Randomizer created is effective and code creates a good environment for practicing and testing binary. Plan and project features demonstrated good collaboration with teammates, such as helping fix errors. Overall, Rayyan was a key contributor to their project and definitely did his share of work.

Grade: 0.83/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants