Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build & packages: integrate npm ci #43

Closed
3 tasks done
dsebastien opened this issue Feb 26, 2018 · 2 comments · Fixed by #558
Closed
3 tasks done

build & packages: integrate npm ci #43

dsebastien opened this issue Feb 26, 2018 · 2 comments · Fixed by #558
Labels
comp: build-main Main build should type: enhancement
Milestone
10.0.0-alpha.4

Comments

@dsebastien
Copy link
Contributor

dsebastien commented Feb 26, 2018 •
edited by SuperITMan
Loading

Goal: improve ci build speed.

For this to work work

  • we first need to have a valid package-lock.json file in the project. It should be valid and point to the npmjs official registry (not our internal nexus).
  • we should remove package-lock.json from .gitignore
  • we should commit the file

https://medium.com/@tomastrajan/how-to-speed-up-continuous-integration-build-with-new-npm-ci-and-package-lock-json-7647f91751a
@dsebastien dsebastien added this to the 10.0.0-alpha.1 milestone Feb 26, 2018
@dsebastien dsebastien added comp: stark-build Stark Build comp: stark-all To apply for all Stark modules labels Feb 28, 2018
@dsebastien dsebastien changed the title Integrate npm ci build & packages: integrate npm ci Mar 1, 2018
@dsebastien dsebastien modified the milestones: 10.0.0-alpha.1, 10.0.0-alpha.2 Mar 2, 2018
@dsebastien dsebastien mentioned this issue Mar 2, 2018
Closed
3 tasks
@SuperITMan SuperITMan mentioned this issue Mar 26, 2018
Merged
3 tasks
@dsebastien
Copy link
Contributor Author

dsebastien commented Mar 26, 2018 •
edited
Loading

We're abandoning this idea for now.
Problems spotted in Travis because our build.sh adapts the dependencies for stark-build ... dependencies which is not cool for package-lock.json

@dsebastien dsebastien removed this from the 10.0.0-alpha.2 milestone Mar 26, 2018
@dsebastien dsebastien added this to the could milestone Mar 26, 2018
@dsebastien dsebastien reopened this Mar 26, 2018
@dsebastien dsebastien mentioned this issue Mar 26, 2018
Closed
This was referenced Mar 28, 2018
Merged
Merged
@dsebastien dsebastien removed this from the could milestone Mar 29, 2018
@dsebastien dsebastien added this to the should milestone Mar 29, 2018
@dsebastien dsebastien added should and removed could labels Mar 29, 2018
@dsebastien
Copy link
Contributor Author

Reverted due to internal NBB issues (proxy).
See:

SuperITMan referenced this issue in SuperITMan/stark Jul 27, 2018
@ageorges-nbb
feat(stark-all): enable npm ci for travis + add package-lock.json + f…
9fa2800 
…orce registry.npmjs.org as registry for

ISSUES CLOSED: #43
SuperITMan referenced this issue in SuperITMan/stark Jul 27, 2018
@ageorges-nbb
feat(stark-all): enable npm ci for travis + add package-lock.json + f…
9b41549 
…orce registry.npmjs.org as registry

ISSUES CLOSED: #43
SuperITMan referenced this issue in SuperITMan/stark Jul 27, 2018
@ageorges-nbb
feat(stark-all): enable npm ci for travis + add package-lock.json + f…
4cc8cf1 
…orce registry.npmjs.org as registry

ISSUES CLOSED: #43
@SuperITMan SuperITMan mentioned this issue Jul 27, 2018
Merged
3 tasks
SuperITMan referenced this issue in SuperITMan/stark Jul 27, 2018
@ageorges-nbb
feat(stark-all): enable npm ci for travis + add package-lock.json + f…
bc368fc 
…orce registry.npmjs.org as registry

ISSUES CLOSED: #43
SuperITMan referenced this issue in SuperITMan/stark Jul 30, 2018
@ageorges-nbb
feat(stark-all): enable npm ci for travis + add package-lock.json + f…
4fd0959 
…orce registry.npmjs.org as registry

ISSUES CLOSED: #43
SuperITMan referenced this issue in SuperITMan/stark Jul 30, 2018
@ageorges-nbb
feat(stark-all): enable npm ci for travis + add package-lock.json + f…
279e0e7 
…orce registry.npmjs.org as registry

ISSUES CLOSED: #43
SuperITMan referenced this issue in SuperITMan/stark Jul 30, 2018
@ageorges-nbb
feat(stark-all): enable npm ci for travis + add package-lock.json + f…
f47d610 
…orce registry.npmjs.org as registry

ISSUES CLOSED: #43
@dsebastien dsebastien modified the milestones: should, 10.0.0-alpha.4 Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: build-main Main build should type: enhancement
Projects
None yet
Milestone
10.0.0-alpha.4
1 participant
@dsebastien