Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: stark-core - circular dependencies detected by Rollup #530

Closed
christophercr opened this issue Jul 18, 2018 · 0 comments · Fixed by #531
Closed

build: stark-core - circular dependencies detected by Rollup #530

christophercr opened this issue Jul 18, 2018 · 0 comments · Fixed by #531

Comments

@christophercr
Copy link
Collaborator

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Rollup displays some warnings due to circular dependencies while building the package:

(!) Circular dependency: dist\packages\stark-core\esm5\src\configuration\entities\application.js -> dist\packages\stark-core\esm5\src\configuration\entities\application\app-config.entity.js -> dist\packages\stark-core\esm5\src\util.js -> dist\packages\stark-core\esm5\src\util\configuration.util.js -> dist\packages\stark-core\esm5\src\configuration\entities\application.js
(!) Circular dependency: dist\packages\stark-core\esm5\src\common.js -> dist\packages\stark-core\esm5\src\common\routes.js -> dist\packages\stark-core\esm5\src\common\routes\routes.js -> dist\packages\stark-core\esm5\src\modules\routing\services.js -> dist\packages\stark-core\esm5\src\modules\routing\services\routing.service.js -> dist\packages\stark-core\esm5\src\modules\logging\services.js -> dist\packages\stark-core\esm5\src\modules\logging\services\logging.service.js -> dist\packages\stark-core\esm5\src\modules\logging\entities.js -> dist\packages\stark-core\esm5\src\modules\logging\entities\logging.entity.js -> dist\packages\stark-core\esm5\src\modules\logging\entities\log-message.entity.js -> dist\packages\stark-core\esm5\src\common.js
(!) Circular dependency: dist\packages\stark-core\esm5\src\modules\logging\reducers.js -> dist\packages\stark-core\esm5\src\modules\logging\reducers\index.js -> dist\packages\stark-core\esm5\src\modules\logging\reducers.js
(!) Circular dependency: dist\packages\stark-core\esm5\src\modules\session\reducers.js -> dist\packages\stark-core\esm5\src\modules\session\reducers\index.js -> dist\packages\stark-core\esm5\src\modules\session\reducers.js
(!) Circular dependency: dist\packages\stark-core\esm5\src\modules\settings\reducers.js -> dist\packages\stark-core\esm5\src\modules\settings\reducers\index.js -> dist\packages\stark-core\esm5\src\modules\settings\reducers.js

Apart from the circular dependency already known due to the validator implementation:

(!) Circular dependency: dist\packages\stark-core\esm5\src\validation\validator.js -> dist\packages\stark-core\esm5\src\validation\validators.js -> dist\packages\stark-core\esm5\src\validation\validators\array-size-range.js -> dist\packages\stark-core\esm5\src\validation\validators\array-size-range\array-size-range.validator.fn.js -> dist\packages\stark-core\esm5\src\validation\validator.js

Expected behavior

No circular dependencies except the known circular dependency of the validator implementation.

Minimal reproduction of the problem with instructions

Run npm run build:stark-core -- --trace to see the full log.

What is the motivation / use case for changing the behavior?

Clean, consistent and stable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant