Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build-prod is taking too much time #572

Closed
SuperITMan opened this issue Jul 31, 2018 · 1 comment · Fixed by #576
Closed

build: build-prod is taking too much time #572

SuperITMan opened this issue Jul 31, 2018 · 1 comment · Fixed by #576

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When running npm run build:prod in showcase, it takes too much and slows down the tests on Travis.

Expected behavior

This should be faster to and should not slow down the tests on Travis

@SuperITMan SuperITMan self-assigned this Jul 31, 2018
@SuperITMan SuperITMan added this to To do in 10.0.0-alpha.5 via automation Jul 31, 2018
@SuperITMan SuperITMan added this to the 10.0.0-alpha.5 milestone Jul 31, 2018
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
@christophercr
Copy link
Collaborator

christophercr commented Jul 31, 2018

As discussed with @SuperITMan, we will adapt the Travis config and the webpack prod config:

  • we will run the uglification process just once and without sourcemaps for every PR. This will speed up the development process.
  • we will run the uglification process 3 times and with sourcemaps for every release (on tag branches) and on nightly builds. In this way we trigger a full prod build at least once a day so we can be sure everything is working as expected.

10.0.0-alpha.5 automation moved this from To do to Done Jul 31, 2018
@SuperITMan SuperITMan removed their assignment Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment