Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: webpack - warning "PurifyPlugin is deprecated and will be removed in 0.7.0" #623

Closed
christophercr opened this issue Aug 10, 2018 · 2 comments · Fixed by #806
Closed
Labels
Milestone

Comments

@christophercr
Copy link
Collaborator

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

A warning is displayed when running the application with webpack on DEV:

WARNING in PurifyPlugin is deprecated and will be removed in 0.7.0

Such warning was introduced in this commit: angular/devkit@cb2703e

Expected behavior

No warnings during webpack builds.

Minimal reproduction of the problem with instructions

Run npm start in the showcase or the starter.

What is the motivation / use case for changing the behavior?

Environment


Angular version: 6.1.x
@christophercr christophercr added the comp: stark-build Stark Build label Aug 10, 2018
@christophercr christophercr added this to the 10.0.0-alpha.5 milestone Aug 10, 2018
@christophercr christophercr added this to To do in 10.0.0-alpha.5 via automation Aug 10, 2018
@christophercr
Copy link
Collaborator Author

christophercr commented Aug 10, 2018

Apparently the PurifyPlugin is deprecated in Angular 6.1.x because Webpack 4 provides the same functionality as this plugin and its TS transformer.

We need to check and see if they provide some guidelines on how to configure Webpack to achieve the same functionality of this plugin.

@christophercr christophercr added this to To do in 10.0.0-beta.0 via automation Sep 6, 2018
@christophercr christophercr removed this from To do in 10.0.0-alpha.5 Sep 6, 2018
@christophercr christophercr removed this from To do in 10.0.0-beta.0 Sep 19, 2018
@christophercr
Copy link
Collaborator Author

christophercr commented Oct 26, 2018

The PurifyPlugin is finally removed in Angular 7 because it is no longer needed as with Webpack 4 and its built-in module concatenation plugin..
See https://github.com/angular/angular-cli/pull/12171/files and angular/angular-cli#12194

So it seems we could just remove the plugin from our webpack config since we are using Angular 6.1.x (no need to wait until we upgrade to Angular 7).

christophercr referenced this issue in christophercr/stark Oct 30, 2018
…s options to improve performanc

ISSUES CLOSED: #623
christophercr referenced this issue in christophercr/stark Oct 30, 2018
…s options to improve performance.

ISSUES CLOSED: #623
christophercr referenced this issue in christophercr/stark Oct 30, 2018
…glifyJs options to improve performance.

ISSUES CLOSED: #623
christophercr referenced this issue in christophercr/stark Oct 30, 2018
…lifyJs options to improve performance.

ISSUES CLOSED: #623
@christophercr christophercr added this to To do in 10.0.0-beta.1 via automation Oct 30, 2018
@christophercr christophercr moved this from To do to Done in 10.0.0-beta.1 Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
10.0.0-beta.1
  
Done
1 participant