You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jwomeara suggested we add a mechanism in which we could drop all visitors into a "verify" state, so that after a visitor is done executing we could immediately validate the resulting query tree based on a number of criteria. So far the criteria might include
Proper parentage
Minimal parens/reference expressions (simplifies logic in other visitors)
Ensure reference expressions have parent reference nodes (some visitors trigger on a reference node)
Expressions like ((F == 'v') || F2 == 'v2') should reduce to (F == 'v' || F2 == 'v2'). Or more formally "no single term child of an intersection or union should be wrapped".
Just want to add a comment that #603 is a bug that directly affects the work here. To summarize, retrieving the source nodes for a marker node may re-parent the source node and invalidate the original query tree.
Expand upon the work done in #880 to validate the query tree structure.
@jwomeara suggested we add a mechanism in which we could drop all visitors into a "verify" state, so that after a visitor is done executing we could immediately validate the resulting query tree based on a number of criteria. So far the criteria might include
Additional ideas and comments are welcome.
The text was updated successfully, but these errors were encountered: