Address extra parens introduced by several visitors. ASTDelayedPredicate detects if a node is already delayed. #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
apmoriarty
commented
May 6, 2021
apmoriarty
commented
- Added RemoveExtraParensVisitor
- PushdownNegationsVisitor now creates unwrapped And/Or nodes
- ASTDelayedPredicate will detect already-delayed nodes and subtrees (avoids double delays)
apmoriarty
requested review from
alerman,
billoley,
cawaring,
drewfarris,
hlgp,
ivakegg,
jschmidt10,
jwomeara,
keith-ratcliffe and
matthpeterson
as code owners
apmoriarty
force-pushed
the
task/StopDoubleWrappingNodes
branch
from
568d487
to
732d33a
Compare
ivakegg
requested changes
May 26, 2021
warehouse/query-core/src/main/java/datawave/query/jexl/visitors/PushdownNegationVisitor.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/jexl/visitors/RemoveExtraParensVisitor.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/planner/DefaultQueryPlanner.java
Show resolved
Hide resolved
warehouse/query-core/src/main/java/org/apache/commons/jexl2/parser/ASTDelayedPredicate.java
Outdated
Show resolved
Hide resolved
...house/query-core/src/test/java/datawave/query/jexl/visitors/PushdownNegationVisitorTest.java
Outdated
Show resolved
Hide resolved
apmoriarty
force-pushed
the
task/StopDoubleWrappingNodes
branch
from
fde79a5
to
5c3f6ee
Compare
apmoriarty
force-pushed
the
task/StopDoubleWrappingNodes
branch
from
7cd19f6
to
1c357b3
Compare
FineAndDandy
requested changes
Jun 21, 2021
FineAndDandy
previously approved these changes
Jun 22, 2021
|
I like that we got a lot of 'free' unit tests by making this update |
Great suggestion |
apmoriarty
force-pushed
the
task/StopDoubleWrappingNodes
branch
from
3e8eb72
to
e1441af
Compare
apmoriarty
changed the base branch from
feature/accumulo-2.0
to
release/version3.2
…ate detects if a node is already delayed.
apmoriarty
force-pushed
the
task/StopDoubleWrappingNodes
branch
from
e1441af
to
2f1f866
Compare
FineAndDandy
previously approved these changes
Jul 19, 2021
…teningRebuildingVisitor.
d-hwang
approved these changes
Jul 19, 2021
FineAndDandy
approved these changes
Jul 22, 2021
hlgp
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.